Re: Document DateStyle effect on jsonpath string()

David E. Wheeler <david@justatheory.com>

From: "David E. Wheeler" <david@justatheory.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Peter Eisentraut <peter@eisentraut.org>, jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-09-11T19:20:50Z
Lists: pgsql-hackers
On Sep 11, 2024, at 15:08, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Right.  I actually lifted the code from convertJsonbScalar in
> jsonb_util.c.
> 
> Here's a more fleshed-out patch with docs and regression test
> fixes.  I figured we could shorten the tests a bit now that
> the point is just to verify that datestyle *doesn't* affect it.

Looks good. Although…

Should it use the database-native stringification standard or the jsonpath stringification standard? In the case of the former, output should omit the “T” time separator and simplify the time zone `07:00` to `07`. But if it’s the latter case, then it’s good as is.

Best,

David




Commits

  1. Make jsonpath .string() be immutable for datetimes.

  2. Improve documentation and testing of jsonpath string() for datetimes.