Re: Use durable_unlink for .ready and .done files for WAL segment removal

Nathan Bossart <bossartn@amazon.com>

From: "Bossart, Nathan" <bossartn@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2018-11-29T15:00:42Z
Lists: pgsql-hackers
On 11/27/18, 3:53 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> On Tue, Nov 27, 2018 at 09:49:29PM +0000, Bossart, Nathan wrote:
>> That sounds good to me.  I was actually thinking of using the same
>> retry counter that we use for pgarch_archiveXlog(), but on second
>> thought, it is probably better to have two independent retry counters
>> for these two unrelated operations.
>
> What I had in mind was two different variables if what I wrote was
> unclear, possibly with the same value, as archiving failure and failure
> with orphan file removals are two different concepts.

+1

Nathan

Commits

  1. Ensure cleanup of orphan archive status files