Re: MySQL-ism help patch for psql

David Christensen <david@endpoint.com>

From: David Christensen <david@endpoint.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Florian Weimer <fweimer@bfk.de>, Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>, Jeff Davis <pgsql@j-davis.com>, pgsql-hackers@postgresql.org, Magnus Hagander <magnus@hagander.net>
Date: 2010-01-21T18:06:18Z
Lists: pgsql-hackers
On Jan 21, 2010, at 12:02 PM, Tom Lane wrote:

> David Christensen <david@endpoint.com> writes:
>> Should the error messages between the SHOW cases and the others be
>> consistent ("ERROR: unsupported command" or similar)?  It's worth
>> noting that this is only in the psql client, but we could simulate  
>> the
>> ereport output from the server.
>
> No.  Not unless you want to simulate it to the point of honoring the
> different verbosity settings, which would greatly expand the size of  
> the
> patch.  We do not try to make the response to "help" look like an  
> error
> message, and I don't see the value of doing so here either.
>
> (I think Florian's real problem with the proposed output is that it's
> ugly, which I agree with --- the formatting is strange.)


I'm with you on that one; I tried to address that in the second  
revision of the patch.  But I'm definitely open to suggestions.

Regards,

David
--
David Christensen
End Point Corporation
david@endpoint.com