Re: Little checksum worker cleanups

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2026-06-24T12:40:56Z
Lists: pgsql-hackers
On 24/06/2026 12:11, Daniel Gustafsson wrote:
>> On 23 Jun 2026, at 22:40, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> 
>> I had another fresh look at datachecksum_state.c while rebasing my "Interrupts vs signals" patch set, and spotted a few minor things that I think should be cleaned up. See commit messages for details.
> 
> Thanks for the postcommit review, all the attached patches LGTM.

Committed, thanks for the review. (I squashed a few of the cosmetic ones)

- Heikki




Commits

  1. Distinguish datacheckums worker invocations more reliably

  2. Minor cleanup around checking datachecksum worker result

  3. Avoid leaving DataChecksumState->worker_pid to an old value

  4. Misc cleanup in datachecksums_state.[ch]