Thread

1. Patch for automated partitioning

   shrish purohit <shrishpurohit@gmail.com> — 2009-10-30T12:25:32Z

   Hi,
   
   Updated Kedar's patch sending on behalf of Kedar.
   
   .tar.bz2 file contains files to be put at
   ./src/include/catalog/pg_partition.h
   ./src/backend/utils/partition
   ./src/test/regress/sql/partition.sql
   
   There are not toomany modifications. It includes improvements for validating
   multi-column partitioned tables.
   propagation of constraints and indexes to child tables. addition of minvalue
   and maxvalue. some bug fixes.
   
   Thanks,
   Shrish
   Persistent Systems Ltd.
   www.persistentsys.com
   

2. Re: Patch for automated partitioning

   Peter Eisentraut <peter_e@gmx.net> — 2009-10-30T15:04:01Z

   On Fri, 2009-10-30 at 17:55 +0530, shrish purohit wrote:
   > Hi, 
   > 
   > Updated Kedar's patch sending on behalf of Kedar.
   > 
   > .tar.bz2 file contains files to be put at 
   > ./src/include/catalog/pg_partition.h
   > ./src/backend/utils/partition
   > ./src/test/regress/sql/partition.sql
   > 
   > There are not toomany modifications. It includes improvements for
   > validating multi-column partitioned tables.
   > propagation of constraints and indexes to child tables. addition of
   > minvalue and maxvalue. some bug fixes.
   > 
   
   Thank you for your contribution, but please read
   <http://petereisentraut.blogspot.com/2009/09/how-to-submit-patch-by-email.html> on how to submit a proper patch by email.  A tarball of scattered files is not a convenient way of working, especially for a nontrivial feature like this.
   
   
   
   

3. Re: Patch for automated partitioning

   Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> — 2009-11-02T07:44:05Z

   shrish purohit <shrishpurohit@gmail.com> wrote:
   
   > Updated Kedar's patch sending on behalf of Kedar.
   > There are not toomany modifications. It includes improvements for validating
   > multi-column partitioned tables.
   
   Thanks, but I'd like to keep the first patch as possible as simple.
   I'll refer your work in the *next* step, especially partition
   triggers and ALTER commands.
   
   I glanced over your patch and find some codes that have room for improvement:
   
     * Need to avoid RANGE and PARTITION to be reserved keywords.
     * Non SQL-based operations are preferred if possible, so need to
       reconsider pg_parse_query().
     * Adding NOTICE message to completionTag is a very bad idea.
       we don't need such feature because users can create trigger
       on the overflow partition to send those messages.
   
   Regards,
   ---
   ITAGAKI Takahiro
   NTT Open Source Software Center