Re: No error checking when reading from file using zstd in pg_dump
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas@vondra.me>,
Evgeniy Gorbanev <gorbanyoves@basealt.ru>,
pgsql-hackers@lists.postgresql.org
Date: 2025-07-01T14:24:40Z
Lists: pgsql-hackers
Attachments
- v8-0001-pg_dump-Fix-compression-API-errorhandling.patch (application/octet-stream) patch v8-0001
> On 26 Jun 2025, at 20:01, Daniel Gustafsson <daniel@yesql.se> wrote: > >> On 26 Jun 2025, at 15:33, Tom Lane <tgl@sss.pgh.pa.us> wrote: > >> So on the whole I prefer the "void" approach. I'm not dead >> set on that though, it's just a niggling worry. > > I think the likelyhood of it being a problem in practice is pretty slim, but > it's still a stronger argument than my "match an API we're still not aligned > with". The attached v7 reverts back to void return. In preparing for concluding this I've attached a v8 which is the patchset in v7 squashed into a single commit with an attempt at a commit message. This version has been tested against v17 and v16 where it applies and passes all tests (the latter isn't as assuring as it should be since there is a lack of testcoverage). -- Daniel Gustafsson
Commits
-
pg_dump: Fix compression API errorhandling
- ec017a305bd4 16.11 landed
- e686010c5b47 19 (unreleased) landed
- 92268b35d04c 17.7 landed
- 8980c724b559 18.0 landed