Horton
Menu

Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY

Álvaro Herrera <alvherre@kurilemu.de>

View thread
From: Álvaro Herrera <alvherre@kurilemu.de>
To: "Antonin Houska" <ah@cybertec.at>, "Michael Paquier" <michael@paquier.xyz>
Cc: "SATYANARAYANA NARLAPURAM" <satyanarlapuram@gmail.com>, "L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-25T16:56:35Z
Lists: pgsql-hackers 
Hi Antonin,

On 2026-04-20, Antonin Houska wrote:

> ok, this is a patch to enhance the tests. It also simplifies
> gen_compressible() a bit and adjusts it so it is (hopefully) more reliable in
> generating compressible values. Now it can be used to reproduce the fix [1].
>
> [1] https://www.postgresql.org/message-id/52301.1776440752%40localhost

Thanks, I think it looks good, but unfortunately I don't see any problems when running this test without your fix (I was assuming that the test would fail). I didn't immediately understand why.  Do you see any failures?

Regards,

-- 
Álvaro Herrera

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. REPACK CONCURRENTLY: fix processing of toasted tuples