Re: Fixing cache pollution in the Kerberos test suite
Jacob Champion <pchampion@vmware.com>
From: Jacob Champion <pchampion@vmware.com>
To: "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "sfrost@snowman.net" <sfrost@snowman.net>
Date: 2021-01-25T19:31:16Z
Lists: pgsql-hackers
Attachments
- v2-test-kerberos-use-a-local-credentials-cache.patch (text/x-patch) patch v2
On Mon, 2021-01-25 at 14:04 -0500, Tom Lane wrote: > Jacob Champion <pchampion@vmware.com> writes: > > On Mon, 2021-01-25 at 13:49 -0500, Tom Lane wrote: > > > Also, why are you only setting the ENV variable within narrow parts > > > of the test script? I'd be inclined to enforce it throughout. > > I considered it and decided I didn't want to pollute the server's > > environment with it, since the server shouldn't need the client cache. > > True, but if it did try to access the cache, accessing the user's > normal cache would be strictly worse than accessing the test cache. That's fair. Attached is a v2 that just sets KRB5CCNAME globally. Makes for a much smaller patch :) --Jacob
Commits
-
Don't clobber the calling user's credentials cache in Kerberos test.
- b8894a3661d4 11.11 landed
- 881933f19422 14.0 landed
- 820aa9ef4c35 12.6 landed
- 366d302d14f7 13.2 landed