Re: pg_amcheck contrib application

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>, Peter Geoghegan <pg@bowt.ie>, Thomas Munro <thomas.munro@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-03-29T23:16:44Z

Lists: pgsql-hackers

Attachments

v13-0001-Refactoring-function-check_tuple_header_and_visi.patch (application/octet-stream) patch v13-0001
v13-0002-Replacing-implementation-of-check_tuple_visibili.patch (application/octet-stream) patch v13-0002
v13-0003-Renaming-report_corruption-as-report_main_corrup.patch (application/octet-stream) patch v13-0003
v13-0004-Checking-toast-separately-from-the-main-table.patch (application/octet-stream) patch v13-0004
(unnamed) (text/plain)


> On Mar 29, 2021, at 1:06 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> Hmm, so this got ~10x bigger from my version. Could you perhaps
> separate it out into a series of patches for easier review? Say, one
> that just fixes the visibility logic, and then a second to avoid doing
> the TOAST check with a buffer lock held, and then more than that if
> there are other pieces that make sense to separate out?

Sure, here are four patches which do the same as the single v12 patch did.

Commits

amcheck: Improve some confusing reports about TOAST problems.
- 50529e5b4e39 14.0 landed
amcheck: Reword some messages and fix an alignment problem.
- 9acaf1a62197 14.0 landed
amcheck: fix multiple problems with TOAST pointer validation
- ec7ffb8096e8 14.0 landed
amcheck: Remove duplicate XID/MXID bounds checks.
- 4573f6a9af6e 14.0 landed
amcheck: Fix verify_heapam's tuple visibility checking rules.
- 3b6c1259f9ca 14.0 landed
nbtree VACUUM: Cope with buggy opclasses.
- 5b861baa550a 14.0 landed
Improve pg_amcheck's TAP test 003_check.pl.
- 87d90ac61fa1 14.0 landed
Fix a confusing amcheck corruption message.
- 4078ce65a0f7 14.0 landed
Doc: add note about how to run the pg_amcheck regression tests.
- 58f57490facd 14.0 cited
In pg_amcheck tests, don't depend on perl's Q/q pack code.
- 945d2cb7d025 14.0 landed
pg_amcheck: Keep trying to fix the tests.
- 9e294d0f34d6 14.0 landed
pg_amcheck: Try to fix still more test failures.
- 24189277f6ff 14.0 landed
Try to avoid apparent platform-dependency in IPC::Run
- f371a4cdba6d 14.0 landed
Fix portability issues in pg_amcheck's 004_verify_heapam.pl.
- 661125612706 14.0 landed
Try to fix compiler warnings.
- d60e61de4fb4 14.0 landed
Add pg_amcheck, a CLI for contrib/amcheck.
- 9706092839db 14.0 landed
Refactor and generalize the ParallelSlot machinery.
- f71519e545a3 14.0 landed
Remove old-style VACUUM FULL (which was known for a little while as
- 0a469c87692d 9.0.0 cited