Horton

Re: Segfault on ANALYZE in SERIALIZABLE isolation

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Sergei Kornilov <sk@zsrv.org>, Joe Wildish <joe-postgresql.org@elusive.cx>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-05-18T19:48:47Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> Not quite - that was about the DML callbacks, this is about the scan itself. And while we have a snapshot allocated, the analyze version of the beginscan intentionally doesn't take a snapshot.

Uh, what?  That's a *huge* regression.  See, eg, 7170268ef.  We
really want ANALYZE to act as though it's reading a normal MVCC
snapshot.

			regards, tom lane

Commits

  1. Fix and improve SnapshotType comments.

  2. tableam: VACUUM and ANALYZE support.