Horton

Re: Autogenerate some wait events code and documentation

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-05-17T09:10:21Z
Lists: pgsql-hackers

Attachments

Hi,

On 5/17/23 10:14 AM, Michael Paquier wrote:
> On Wed, May 17, 2023 at 08:31:53AM +0200, Drouvot, Bertrand wrote:
>> Did it that way in V9 attached and the sorting does look like what
>> we expect now.
> 
> Yes, the order of the items in the individual tables is fine, but this
> is still a bit incorrect for the classes?  Note that the tables for
> the LWLock and Lock are still in reverse order :)

Sorry did not pay enough attention to it ;-(

> +foreach $waitclass (sort keys %hashwe)
> 
> Meaning that you may want to add an extra case-insensitive rule for
> the sorting on this line for the SGML docs (also the C part, I guess,
> but we care less).

Yeap, done in V10 for sgml and the C part too (for consistency).

>> Agree, V9 does now apply on top of v2-0001-Introducing-WAIT_EVENT_EXTENSION-and-WAIT_EVENT_B.patch
>> (just shared in [1]).
> 
> If you don't send both patches in the same message the CF bot is going
> to complain as v9-0001 is not able to apply independently of the other
> patch v2-0001 on the other thread 

Yeah, good point, attaching both here to keep the CF bot happy.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Add "ABI_compatibility" regions to wait_event_names.txt

  2. Remove column for wait event names in wait_event_names.txt

  3. Use more consistent names for wait event objects and types

  4. Add information about line contents on parsing failure of wait_event_names.txt

  5. Remove double quotes from the second column of wait_event_names.txt

  6. Generate automatically code and documentation related to wait events

  7. Refactor some code related to wait events "BufferPin" and "Extension"

  8. doc: Fix ordering of entries in wait event table for I/O type