Re: type in basebackup_incremental.c ?
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-04-11T10:15:26Z
Lists: pgsql-hackers
> On 11 Apr 2024, at 11:49, Daniel Westermann (DWE) <daniel.westermann@dbi-services.com> wrote: > > Hi, > > /* > * we expect the find the last lines of the manifest, including the checksum, > * in the last MIN_CHUNK bytes of the manifest. We trigger an incremental > * parse step if we are about to overflow MAX_CHUNK bytes. > */ > > Shouldn't this be: > /* > * we expect to find the last lines of the manifest,... > */ That sounds about right, and since it's a full sentence it should also start with a capital 'W': "We expect to find the..". -- Daniel Gustafsson