Horton

Re: some more pg_dump refactoring

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-07-09T14:14:47Z
Lists: pgsql-hackers

Attachments

On 2020-07-08 06:42, Fabien COELHO wrote:
>> What do you think about this patch to reorganize the existing code from that
>> old commit?
> 
> I think it is a definite further improvement.
> 
> Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to
> me.

Thanks.  I have committed that, and attached is my original patch 
adjusted to this newer style.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. pg_dump: Reorganize dumpFunc() and dumpAgg()

  2. pg_dump: Further reorganize getTableAttrs()

  3. pg_dump: Reorganize getTableAttrs()