Re: Dead code in ps_status.c
Michael Banck <mbanck@gmx.net>
From: Michael Banck <mbanck@gmx.net>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-08-26T15:17:28Z
Lists: pgsql-hackers
Hi, On Tue, Aug 26, 2025 at 03:55:30PM +0200, Michael Banck wrote: > On Thu, Feb 16, 2023 at 04:52:33PM +1300, Thomas Munro wrote: > > Therefore I think it is safe to drop the PS_USE_PS_STRING and > > PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments > > and macro tests, and prune the defunct configure/meson probe. > > I noticed Postgres no longer updates the process title on the Hurd, this > is because this was removed along other legacy platforms in this commit > as it was using PS_USE_PS_STRING. By the way, on the back branches from 13-15 (before the above commit) process title changes don't work either, presumably because __hurd__ (as opposed to __GNU__ and __gnu_hurd__) has not been defined on GNU/Hurd for ages (or ever?), see https://github.com/gcc-mirror/gcc/blob/master/gcc/config/gnu.h#L25 So in case this get backpatched, I think it should be changed to PS_USE_CLOBBER_ARGV there as well. Michael
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Define PS_USE_CLOBBER_ARGV on GNU/Hurd.
- 29a3e22f3568 14.21 landed
- 3995e4a9d8c6 15.16 landed
- 32b236644d33 19 (unreleased) landed
- bcfca332f100 18.2 landed
- d66a922f9247 17.8 landed
- a1407daded69 16.12 landed
-
Remove obsolete platforms from ps_status.c.
- d2ea2d310dfd 16.0 landed