Horton

Re: Possible bug: SQL function parameter in window frame definition

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Alastair McKinley <a.mckinley@analyticsengines.com>, "pgsql-general\@lists.postgresql.org" <pgsql-general@lists.postgresql.org>
Date: 2019-09-30T20:25:36Z
Lists: pgsql-hackers, pgsql-general 
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
>  Tom> Hmm.  I think this is a reasonable direction to go in, but
>  Tom> what about groupingSets and rowMarks?

> groupingSets ultimately contains nothing but numbers which are
> meaningless without reference to the matching groupClause list. So
> anything that cares about those is really going to have to process them
> in its Query case in the walker function in order to get at both
> clauses.

Ah.  I was thinking there were SortGroupClauses under them, but that
was based on an overly hasty reading of the parsenodes.h comments.

No further complaints.

			regards, tom lane

Commits

  1. Selectively include window frames in expression walks/mutates.