Horton

Re: postgres_fdw, dblink: Validate use_scram_passthrough values

Matheus Alcantara <matheusssilv97@gmail.com>

View thread
From: Matheus Alcantara <matheusssilv97@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-27T18:22:15Z
Lists: pgsql-hackers 
On 27/05/26 11:41, Fujii Masao wrote:
> Hi,
> 
> The use_scram_passthrough option in postgres_fdw and dblink is
> intended to accept only boolean values. However, unlike other boolean
> options such as keep_connections, its value is not currently
> validated.
> 
> As a result, invalid values are accepted unexpectedly, for example:
> 
> CREATE SERVER test_server
>    FOREIGN DATA WRAPPER postgres_fdw
>    OPTIONS (use_scram_passthrough 'invalid');
> 
> Attached patch updates postgres_fdw and dblink to validate
> use_scram_passthrough values and throw an error for invalid input.
> 

Hi,

Thank you for the patch. It looks correct to me and it fix the issue 
as mentioned.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com