Thread

Re: Patch for migration of the pg_commit_ts directory

ls7777 <ls7777@yandex.ru> — 2025-10-14T15:53:04Z

  Hi,


  
    I applied the diff file.
  
  
    Deleted the $ts variable.
  
  
     
  


   


   


  ----------------


  Кому: 'ls7777' (ls7777@yandex.ru);


  Копия: pgsql-hackers@postgresql.org, orlovmg@gmail.com, amit.kapila16@gmail.com;


  Тема: Patch for migration of the pg_commit_ts directory;


  14.10.2025, 09:27, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>:


  

    Hi,

    

    Thanks for updating the patch.

    

    ```

    +my ($xid,$ts) = $resold =~ /\s*(\d+)\s*\|(.*)/;

    ```

    

    Per my understanding $ts is not used here. Can you remove it?

    

    Apart from above, I found some cosmetic issues. Please see attached

    my fix which can be applied atop HEAD. Can you check and include if

    it is OK?

    

    Best regards,

    Hayato Kuroda

    FUJITSU LIMITED