Thread

  1. Re: Sequence Access Methods, round two

    Andrei Lepikhov <lepihov@gmail.com> — 2026-05-15T09:04:37Z

    On 07/01/2026 06:32, Michael Paquier wrote:
    > For now, I am sending a rebased v28.  This stuff needed a refresh.
    
    Here is a rebased version of the patch set.
    It is generally looks quite elegant. Of course, an int64 value seems a little
    restrictive, but in practice, with four different algorithms on board, I don't
    need a value larger than 64 bits at this moment.
    
    Notes on the snowflake sequence (0007):
    1. The gettimeofday() might be called out of the loop before the exclusive lock
    is acquired.
    2. At least in my experience, gettimeofday does not always return monotonically
    increased values. So, it makes sense to save the used value inside the 'seq'
    structure and, if gettimeofday returned an earlier value, just increase this
    cached value a little.
    3. Sleep call under the lock. It might not be so inevitable, and call it only
    when the time value stays the same.
    
    -- 
    regards, Andrei Lepikhov,
    pgEdge