Re: MSVC buildfarm critters are not running modules' TAP tests
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-09-08T22:14:52Z
Lists: pgsql-hackers
On 9/8/19 5:59 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 9/8/19 12:07 PM, Tom Lane wrote:
>>> It looks to me like the reason is that src/tools/msvc/vcregress.pl's
>>> subroutine subdircheck isn't considering the possibility that
>>> subdirectories of src/test/modules contain TAP tests. The
>>> same code is used for contrib, so several existing TAP tests
>>> are being missed there too.
>> Actually, I think vcregress.pl is OK, this is a gap in the buildfarm
>> client's coverage that will be fixed when I make a new release.
> Hm. Changing the buildfarm script would be an alternative way to
> fix the issue so far as the buildfarm is concerned, but it doesn't
> seem like it provides any useful way for one to manually invoke
> the tests on Windows. Or am I missing something about how that's
> usually done?
>
>
The invocation is:
vcregress.pl taptest [ PROVE_FLAGS=xxx ] directory
directory needs to be relative to $topdir, so something like:
vcregress.pl taptest src/test/modules/test_misc
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Expand properly list of TAP tests used for prove in vcregress.pl
- 3d12829ccb16 9.4.25 landed
- bfd6db8560c5 9.5.20 landed
- e25c87a8e1a8 9.6.16 landed
- 9b9f0d790476 10.11 landed
- 8da17f3f5061 11.6 landed
- dc92bf5cad7c 12.0 landed
- 9d6e1ec5ceed 13.0 landed
-
Avoid using INFO elevel for what are fundamentally debug messages.
- db438318997b 13.0 cited