Horton

Re: Add missing PGDLLIMPORT markings

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Jacob Champion <jacob.champion@enterprisedb.com>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, Andres Freund <andres@anarazel.de>, Rahila Syed <rahilasyed90@gmail.com>
Date: 2025-04-09T11:48:06Z
Lists: pgsql-hackers

Attachments

> On 9 Apr 2025, at 12:02, Peter Eisentraut <peter@eisentraut.org> wrote:

-extern const pg_be_sasl_mech pg_be_oauth_mech;
+extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;
+1 on this.

> Btw., this new variable in memutils.h
> 
>    extern dsa_area *area;
> 
> could probably do with a less generic name?

Good point, unless objected to I'll apply the attached renaming which then also
contain the PGDLLIMPORT addition.

--
Daniel Gustafsson

Commits

  1. Add missing PGDLLIMPORT markings

  2. Rename global variable backing DSA area