Horton
Menu

Re: SQL/JSON: functions

Nikita Glukhov <n.gluhov@postgrespro.ru>

View thread
From: Nikita Glukhov <n.gluhov@postgrespro.ru>
To: Oleg Bartunov <obartunov@postgrespro.ru>, Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>, Simon Riggs <simon@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Pavel Stehule <pavel.stehule@gmail.com>
Date: 2018-03-15T17:04:07Z
Lists: pgsql-hackers

Attachments

Attached 13th version of the patches:

* Subtransactions in PG_TRY/CATCH in ExecEvalJsonExpr() were made unconditional,
   regardless of the volatility of expressions.

* PG_TRY/CATCH in ExecEvalExprPassingCaseValue() was removed along with the
   entire function.

On 15.03.2018 11:08, Oleg Bartunov wrote:

> On 14 Mar 2018 17:11, "Alexander Korotkov" <a.korotkov@postgrespro.ru 
> <mailto:a.korotkov@postgrespro.ru>> wrote:
>
>     On Wed, Mar 14, 2018 at 2:10 AM, Andres Freund <andres@anarazel.de
>     <mailto:andres@anarazel.de>> wrote:
>
>         On 2018-03-14 07:54:35 +0900, Michael Paquier wrote:
>         > On Tue, Mar 13, 2018 at 04:08:01PM +0300, Oleg Bartunov wrote:
>         > > The docs are here
>         > >
>         https://github.com/obartunov/sqljsondoc/blob/master/README.jsonpath.md
>         <https://github.com/obartunov/sqljsondoc/blob/master/README.jsonpath.md>
>         > >
>         > > It's not easy to write docs for SQL/JSON in xml, so I
>         decided to write in more
>         > > friendly way. We'll have time to convert it to postgres
>         format.
>         >
>         > If you aim at getting a feature committed first without its
>         > documentation, and getting the docs written after the
>         feature freeze
>         > using a dedicated open item or such, this is much acceptable
>         in my
>         > opinion and the CF is running short in time.
>
>         Given that this patch still uses PG_TRY/CATCH around as wide
>         paths of
>         code as a whole ExecEvalExpr() invocation,
>
>     I agree that we should either use PG_TRY/CATCH over some small and
>     safe
>     codepaths or surround PG_TRY/CATCH with subtransactions.
>     PG_TRY/CATCH over
>     ExecEvalExpr() looks really unacceptable.
>
>         basically has gotten no
>         review, I don't see this going anywhere for v11.
>
>
>     I wouldn't be co categorical at this point. Patchset is there for
>     about year.
>     Some parts of code received more of review while some parts
>     receives less.
>     We can surround all dangerous PG_TRY/CATCH pairs with subtransactions,
>     tolerate performance penalty and leave further optimizations for
>     future releases.
>
>
> Agree it's not difficult.
>
>     In worst case, we can remove codepaths which use PG_TRY/CATCH and
>     leave only ERROR ON ERROR behavior of SQL/JSON.
>
>
> No-no, json user will be really upset on this. Our goal is to be the 
> first relational database with strong standard compliance.

-- 
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. JSON_TABLE: Add support for NESTED paths and columns

  2. Add basic JSON_TABLE() functionality

  3. Add SQL/JSON query functions

  4. Add soft error handling to some expression nodes

  5. Adjust populate_record_field() to handle errors softly

  6. Refactor code used by jsonpath executor to fetch variables

  7. Add more SQL/JSON constructor functions

  8. SQL/JSON: support the IS JSON predicate

  9. SQL/JSON: add standard JSON constructor functions

  10. Improve readability of SQL/JSON documentation.

  11. Documentation for SQL/JSON features

  12. RETURNING clause for JSON() and JSON_SCALAR()

  13. SQL JSON functions

  14. SQL/JSON query functions

  15. IS JSON predicate

  16. SQL/JSON constructors

  17. Common SQL/JSON clauses

  18. Doc: remove obsolete entries in table of BRIN strategy numbers.

  19. Doc: standardize markup a bit more.

  20. Make pg_regress.c unset PGDATABASE during make installcheck.

  21. Fix handling of GENERATED columns in CREATE TABLE LIKE INCLUDING DEFAULTS.