Horton

Re: Preventing abort() and exit() calls in libpq

Jacob Champion <pchampion@vmware.com>

View thread View on postgr.es
From: Jacob Champion <pchampion@vmware.com>
To: "peter.eisentraut@enterprisedb.com" <peter.eisentraut@enterprisedb.com>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>
Cc: "daniel@yesql.se" <daniel@yesql.se>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "michael@paquier.xyz" <michael@paquier.xyz>
Date: 2021-06-30T22:41:01Z
Lists: pgsql-hackers 
On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
> I wrote:
> > Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> > > Could we set this rule up a little bit differently so that it is only 
> > > run when the library is built.
> > > Right now, make world on a built tree makes 17 calls to this "nm" line, 
> > > and make check-world calls it 81 times.  I think once would be enough. ;-)
> > Hmm, didn't realize that would happen.  Will see what can be done.
> 
> Looks like we'd have to make use of a dummy stamp-file, more or less
> as attached.  Any objections?

Spitballing -- if you don't like the stamp file, you could add the
check to the end of the $(shlib) rule, surrounded by an ifeq check.
Then .DELETE_ON_ERROR should take care of the rest, I think.

--Jacob

Commits

  1. Further restrict the scope of no-exit()-in-libpq test.

  2. Improve build-time check that libpq doesn't call exit().

  3. Fix portability fallout from commit dc227eb82.

  4. Add a build-time check that libpq doesn't call exit() or abort().