Re: [UNVERIFIED SENDER] Re: pg_upgrade can result in early wraparound on databases with high transaction load
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>, "Drouvot, Bertrand"
<bdrouvot@amazon.com>, Andres Freund <andres@anarazel.de>,
Justin Pryzby <pryzby@telsasoft.com>, Noah Misch <noah@leadboat.com>,
Jason Harvey <jason@reddit.com>, Peter Geoghegan <pg@bowt.ie>,
pgsql-hackers@postgresql.org, "Tharakan, Robins" <tharar@amazon.com>
Date: 2022-07-05T21:25:43Z
Lists: pgsql-hackers, pgsql-general
On 2022-07-05 Tu 15:17, Tom Lane wrote: > Andrew Dunstan <andrew@dunslane.net> writes: >> So it's taken us a year to discover the issue :-( Perhaps if we're going >> to say we support upgrades back to 9.0 we should have some testing to be >> assured we don't break it without knowing like this. I'll see if I can >> coax crake to do that - it already tests back to 9.2. > Hmm ... could you first look into why 09878cdd4 broke it? I'd supposed > that that was just detecting situations we must already have dealt with > in order for the pg_upgrade test to work, but crake's not happy. It's complaining about this: andrew@emma:HEAD $ cat ./inst/REL9_6_STABLE-20220705T160820.039/incompatible_polymorphics.txt In database: regression aggregate: public.first_el_agg_f8(double precision) I can have TestUpgradeXVersion.pm search for and remove offending functions, if that's the right fix. I note too that drongo is failing similarly, but its pg_upgrade output directory is missing, so 4fff78f009 seems possibly shy of a load w.r.t. MSVC. I will investigate. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
Commits
-
Refuse upgrades from pre-9.0 clusters
- ccf3408cff53 14.13 landed
- bcd2be0c2f7e 12.20 landed
- b030697d36d5 13.16 landed
-
pg_resetxlog: add option to set oldest xid & use by pg_upgrade
- 74cf7d46a91d 15.0 cited
-
Stamp 11.2.
- 6cd404b344f7 11.2 cited
-
Track the current XID wrap limit (or more accurately, the oldest unfrozen
- 25ec228ef760 9.0.0 cited