Horton

Re: [PATCH] Improve geometric types

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: emre@hasegeli.com, Thomas Munro <thomas.munro@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Date: 2018-07-26T15:12:50Z
Lists: pgsql-hackers

Attachments

On 07/11/2018 07:13 PM, Emre Hasegeli wrote:
> New versions are attached after the <float.h> patch got in.  I noticed
> tests failing on Windows [1] and added alternative .out file.
> 
> [1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.5235
> 

The version posted about two weeks ago is slightly broken - AFAICS the 
float.h includes in geo_ops.c and gistproc.c need to be part of 0002, 
not 0003. Attached is a version fixing that.

Barring objections, I'll get this committed over the next few days, once 
I review all the individual parts once more. I'm planning to commit the 
6 parts separately, as submitted. No backpatching, as discussed before.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Improve test coverage of geometric types

  2. Fix problems in handling the line data type

  3. Use the built-in float datatypes to implement geometric types

  4. Remove remaining GEODEBUG references from geo_ops.c

  5. Provide separate header file for built-in float types

  6. Refactor geometric functions and operators

  7. Fix crash in close_ps() for NaN input coordinates.

  8. Fix GiST index build for NaN values in geometric types.

  9. Enable building with Visual Studion 2013.

  10. Suppress -0 in the C field of lines computed by line_construct_pts().