Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Heikki Linnakangas <hlinnaka@iki.fi>
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Masahiko Sawada <sawada.mshk@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-11-18T23:41:30Z
Lists: pgsql-hackers
On 19/11/2024 01:20, Masahiko Sawada wrote: > I realized that building test_radixtree.c with TEST_SHARED_RT fails > because it eventually sets RT_SHMEM when #include'ing radixtree.h but > it's missing some header files to include. I've attached a patch to > include necessary header files in radixtree.h to make it > self-contained. +1. Please make sure the #includes are in alphabetical order. While we're at it, I noticed that lib/radixtree.h includes "postgres.h". That's against our usual convention. -- Heikki Linnakangas Neon (https://neon.tech)
Commits
-
Include necessary header files in radixtree.h.
- 724890ffb75c 18.0 landed
- a12b0f3a9dc0 17.3 landed