Re: On non-Windows, hard depend on uselocale(3)

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Thomas Munro <thomas.munro@gmail.com>, Michael Paquier <michael@paquier.xyz>

Cc: Andrew Dunstan <andrew@dunslane.net>, Tristan Partin <tristan@neon.tech>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-11-26T16:23:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert "Tidy up locale thread safety in ECPG library."
- 3c8e463b0d88 18.0 landed
Tidy up locale thread safety in ECPG library.
- 8e993bff5326 18.0 landed
Revert "Blind attempt to fix _configthreadlocale() failures on MinGW."
- a62d90f2e5cb 18.0 landed
Require ucrt if using MinGW.
- 1758d4244616 18.0 landed
Remove configure check for _configthreadlocale().
- f1da075d9a03 18.0 landed
Simplify checking for xlocale.h
- 9c2a6c5a5f4b 18.0 landed
All supported systems have locale_t.
- 8d9a9f034e92 17.0 cited

Attachments

0001-doc-Update-some-outdated-installation-info-related-t.patch (text/plain) patch 0001

On 25.11.24 01:57, Thomas Munro wrote:
> Thanks.  I'm going to have a go at adjusting the docs myself so I can
> get this committed.  Invitation remains open for someone closer to the
> topic to rewrite in a later commit as required for maximum utility to
> the reader (I'm never going to install MSYS2, or Windows, I just want
> to blow away as much dead code as possible here as it's in the way of
> multithreading and other modernisation projects).

Attached is a simple proposal.  The section about MinGW can be replaced 
mostly by "use MSYS2".  That's also what CI and the buildfarm uses. 
Anyone who strays from that can figure it out themselves.

In the Visual Studio section, there was some text that recommended 
getting flex and bison via MinGW, which seemed clearly outdated.  I put 
in the URL that the CI images use.  I don't know if there are other 
common sources, but that one seems good enough.