Horton

Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

Chao Li <li.evan.chao@gmail.com>

View thread View on postgr.es
From: Chao Li <li.evan.chao@gmail.com>
To: Steve Lau <stevelauc@outlook.com>
Cc: pgsql-hackers@postgresql.org
Date: 2025-09-21T22:41:23Z
Lists: pgsql-hackers 

> On Sep 21, 2025, at 22:48, Steve Lau <stevelauc@outlook.com> wrote:
> 
> Hi hackers! 
> 
> Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:
> 
> > join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the
> 
> Regards,
> steve
>  
> <v1-0001-Correct-RangeTblEntry.join_using_alias-comment-to-re.patch>


“alias” is the second field of structure RangeTblEntry, so it should be above “join_using_alias”.

The change looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

  1. Fix misleading comment in RangeTblEntry