Horton

Re: [PATCH] OAuth: fix performance bug with stuck multiplexer events

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2025-08-13T11:34:38Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. oauth: Always link with -lm for floor()

  2. oauth: Add unit tests for multiplexer handling

  3. oauth: Ensure unused socket registrations are removed

  4. oauth: Remove expired timers from the multiplexer

  5. oauth: Remove stale events from the kqueue multiplexer

  6. oauth: Track total call count during a client flow

On 2025-08-12 Tu 6:25 PM, Jacob Champion wrote:
> On Tue, Aug 12, 2025 at 3:21 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>> I don't think that's quite going to work. The buildfarm will now get a
>> "target not found"  in the without-curl case, I suspect. I think you'll
>> need an alternative definition of the check target.
> We're still including Makefile.global, so the targets are still there;
> they just won't add the libpq-oauth specific pieces. So `make check -C
> src/interfaces/libpq-oauth` still works on my machine. Or have I
> misunderstood the problem?
>

Oh, I see, and because the default definition of check doesn't call 
prove_check nothing is done. OK, sorry for the noise.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com