Thread

Re: [PATCH] Update comment in nodeBitmapHeapscan.c

Daniel Gustafsson <daniel@yesql.se> — 2025-12-09T14:37:39Z

> On 9 Dec 2025, at 15:02, Anton Haglund <antonh@accum.se> wrote:
> On 2025-12-09 14:13, Daniel Gustafsson wrote:
>>> On 9 Dec 2025, at 14:04, Anton Haglund <antonh@accum.se> wrote:

>>> - * ExecBitmapHeapNext workhorse for above
>> 
>> Judging by the commitlog that function has never existed, and the workhorse
>> referred to is BitmapHeapNext (which is not part of the interface).
>> 
>> Thanks for your contribution, but in the future please email pgsql-hackers
>> instead of all committers directly.  We do all our development publically
>> archived on pgsql-hackers, and you don't even need to be subscribed to send
>> (but your email will be subject to moderation).
> 
> The comment was added to src/backend/executor/nodeBitmapHeapscan.c in
> commit 4a8c5d0375f17d8d961a280cbb640996aaa8bf0d, by Tom Lane in 2005.
> But as you say, there are no traces of that function ever existed.

Correct, the function has never existed, it was a typo(ish) in the original
commit that went unnoticed for two decades.  And sorry for missing that you did
indeed email -hackers as well, I missed that when reading the To: line earlier.
Thanks for contributing to postgres!

--
Daniel Gustafsson