MSVC buildfarm critters are not running modules' TAP tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Date: 2019-09-08T16:07:56Z
Lists: pgsql-hackers
Attachments
- make-vcregress-run-all-tap-tests-1.patch (text/x-diff) patch
I noticed $subject while checking to see if commit db4383189's new test script was behaving properly in the buildfarm. dory, for one, should be running it but it just isn't. It looks to me like the reason is that src/tools/msvc/vcregress.pl's subroutine subdircheck isn't considering the possibility that subdirectories of src/test/modules contain TAP tests. The same code is used for contrib, so several existing TAP tests are being missed there too. I took a stab at fixing this, but lacking a Windows environment to test in, I can't be sure if it works. The attached does kinda sorta work if I run it in a Linux environment --- but I found that system() doesn't automatically expand "t/*.pl" on Linux. Is that an expected difference between Linux and Windows perl? I hacked around that by adding a glob() call in sub tap_check, as seen in the first hunk below, but I'm not very sure if that hunk should get committed or not. For ease of review, I did not re-indent the main part of sub subdircheck, though that needs to be done before committing. Anybody with suitable tools care to test/commit this? regards, tom lane
Commits
-
Expand properly list of TAP tests used for prove in vcregress.pl
- 3d12829ccb16 9.4.25 landed
- bfd6db8560c5 9.5.20 landed
- e25c87a8e1a8 9.6.16 landed
- 9b9f0d790476 10.11 landed
- 8da17f3f5061 11.6 landed
- dc92bf5cad7c 12.0 landed
- 9d6e1ec5ceed 13.0 landed
-
Avoid using INFO elevel for what are fundamentally debug messages.
- db438318997b 13.0 cited