Horton

Re: Remove useless casting to the same type

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Jacob Champion <jacob.champion@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-11-28T08:40:55Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove useless casting to same type

  2. Simplify hash_xlog_split_allocate_page()

On 25.11.25 06:46, Bertrand Drouvot wrote:
>> Maybe we should make the code compile cleanly under
>> -Wformat-signedness at some point...
> good idea, will give it a try later on outside the context of this patch.

I test this once in a while and fix the issues that I find.  But it's 
very picky and you will find difficult to fix problems like the fact 
that the signedness of enums is implementation-defined, and so the only 
portable fix there would be to add more casts.

I think it could be useful to tighten the source code with respect to 
implicit integer conversions, using warnings such as -Wsign-conversion 
and -Wconversion as well as -Wformat-signedness.  There are surely 
hidden overflow or truncation issues similar to CVE-2025-12818 hidden 
somewhere.  But explicit casts defeat those warnings, so removing 
unnecessary casts is a good step on the way there.