Re: Removing pgsql_tmp files

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Michael Glaesemann <michael.glaesemann@myyearbook.com>, pgsql-general <pgsql-general@postgresql.org>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2010-11-09T02:46:28Z

Lists: pgsql-hackers

Attachments

fix-temp-file-unlink.patch (text/x-patch) patch

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Tom Lane's message of lun nov 08 22:29:28 -0300 2010:
>> I think we need to re-order the operations there to ensure that the
>> unlink will still happen if the ereport gets interrupted.

> Would it work to put the removal inside a PG_CATCH block?

Well, that still begs the question of what to do exactly.  After some
thought I believe the attached is the best fix.

			regards, tom lane