Horton

Re: partitioning and identity column

Alexander Law <exclusion@gmail.com>

View thread View on postgr.es
From: Alexander Lakhin <exclusion@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-02-20T06:00:00Z
Lists: pgsql-hackers 
20.02.2024 07:57, Ashutosh Bapat wrote:
>> Could you please name functions, which you suspect, for me to recheck them?
>> Perhaps we should consider fixing all of such functions, in light of
>> b0f7dd915 and d57b7cc33...
> Looks like the second commit has fixed all other places I knew except
> Identity related functions. So worth fixing identity related functions
> too. I see
> dropconstraint_internal() has two calls to check_stack_depth() back to
> back. The second one is not needed?

Yeah, that's funny. It looks like such a double protection emerged
because Alvaro protected the function (in b0f7dd915), which was waiting for
adding check_stack_depth() in the other thread (resulted in d57b7cc33).

Thank you for spending time on this!

Best regards,
Alexander

Commits

  1. Fix assorted bugs related to identity column in partitioned tables

  2. Remove extra check_stack_depth() from dropconstraint_internal()

  3. Support identity columns in partitioned tables

  4. doc: Add Identity Column section under Data Definition chapter

  5. Assert that partition inherits from only one parent in MergeAttributes()

  6. doc: Decorate PostgreSQL with productname tag

  7. Fix prologue of get_partition_ancestors()