Horton

Thread

Commits

  1. Add some const qualifiers

  1. Add const qualifiers

    David Steele <david@pgmasters.net> — 2023-09-01T15:39:24Z

    Hackers,

I noticed that there was a mismatch between the const qualifiers for 
excludeDirContents in src/backend/backup/backup/basebackup.c and 
src/bin/pg_rewind/file_map.c and that led me to use ^static const.*\*.*= 
to do a quick search for similar cases.

I think at the least we should make excludeDirContents match, but the 
rest of the changes seem like a good idea as well.

Regards,
-David

  2. Re: Add const qualifiers

    David Steele <david@pgmasters.net> — 2023-09-09T20:03:37Z

    On 9/1/23 11:39, David Steele wrote:
> Hackers,
> 
> I noticed that there was a mismatch between the const qualifiers for 
> excludeDirContents in src/backend/backup/backup/basebackup.c and 
> src/bin/pg_rewind/file_map.c and that led me to use ^static const.*\*.*= 
> to do a quick search for similar cases.
> 
> I think at the least we should make excludeDirContents match, but the 
> rest of the changes seem like a good idea as well.

Added to 2023-11 CF.

Regards,
-David

  3. Re: Add const qualifiers

    Peter Eisentraut <peter@eisentraut.org> — 2023-09-26T10:34:34Z

    On 09.09.23 21:03, David Steele wrote:
> On 9/1/23 11:39, David Steele wrote:
>> Hackers,
>>
>> I noticed that there was a mismatch between the const qualifiers for 
>> excludeDirContents in src/backend/backup/backup/basebackup.c and 
>> src/bin/pg_rewind/file_map.c and that led me to use ^static 
>> const.*\*.*= to do a quick search for similar cases.
>>
>> I think at the least we should make excludeDirContents match, but the 
>> rest of the changes seem like a good idea as well.
> 
> Added to 2023-11 CF.

committed

  4. Re: Add const qualifiers

    David Steele <david@pgmasters.net> — 2023-09-26T20:19:12Z

    On 9/26/23 06:34, Peter Eisentraut wrote:
> On 09.09.23 21:03, David Steele wrote:
>> On 9/1/23 11:39, David Steele wrote:
>>> Hackers,
>>>
>>> I noticed that there was a mismatch between the const qualifiers for 
>>> excludeDirContents in src/backend/backup/backup/basebackup.c and 
>>> src/bin/pg_rewind/file_map.c and that led me to use ^static 
>>> const.*\*.*= to do a quick search for similar cases.
>>>
>>> I think at the least we should make excludeDirContents match, but the 
>>> rest of the changes seem like a good idea as well.
>>
>> Added to 2023-11 CF.
> 
> committed

Thank you, Peter!