Re: Patch: incorrect array offset in backend replication tar header

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Brian Weaver <cmdrclueless@gmail.com>, Marko Tiikkaja <pgmail@joh.to>, pgsql-hackers@postgresql.org
Date: 2012-09-27T22:45:27Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Ah, yeah, that should also work I guess. But you could also just leave
> the the data in the temporary tarfile the whole time. IIRC, you can
> just cat one tarfile to the end of another one, right?

Not if they're written according to spec, I think.  There is an EOF
marker consisting of 2 blocks of zeroes (which pg_dump is failing to
create correctly, but that's a bug not a feature).  Possibly you could
strip the EOF marker though, if the file join code is allowed to be
something smarter than "cat".

			regards, tom lane