Horton

Re: pg_dump crash on identity sequence with not loaded attributes

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Artur Zakirov <zaartur@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2024-12-10T15:29:52Z
Lists: pgsql-bugs 
Artur Zakirov <zaartur@gmail.com> writes:
> On Mon, 9 Dec 2024 at 22:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> -       if (owning_tab->dobj.dump == DUMP_COMPONENT_NONE &&
>> +       if ((owning_tab->dobj.dump & DUMP_COMPONENT_DEFINITION) &&

> I think it is necessary to use negation in this condition.

D'oh, of course.  But what's your thoughts on the other points?
Is this what we want to do at all?

			regards, tom lane

Commits

  1. Fix possible crash in pg_dump with identity sequences.

  2. Do not dump identity sequences with excluded parent table