Horton

Thread

Commits

  1. Remove unused totalrows parameter in compute_expr_stats

  2. Extended statistics on expressions

  1. Removing unused parameter in compute_expr_stats

    Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> — 2024-12-26T09:40:52Z

    Hi hackers,

I'm sharing a small patch that removes an unused parameter (totalrows) 
from compute_expr_stats function in extended_stats.c .

This function originally appeared in commit 
a4d75c86bf15220df22de0a92c819ecef9db3849, which introduced extended 
statistics on expressions. From what I can see, total rows is never used 
in the current implementation, so this patch removes it

If there are reasons to keep this parameter, or if there's anything I 
might have missed, I'd be happy to discuss further.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

  2. Re: Removing unused parameter in compute_expr_stats

    David Rowley <dgrowleyml@gmail.com> — 2024-12-26T21:53:51Z

    On Thu, 26 Dec 2024 at 22:41, Ilia Evdokimov
<ilya.evdokimov@tantorlabs.com> wrote:
> I'm sharing a small patch that removes an unused parameter (totalrows)
> from compute_expr_stats function in extended_stats.c .

Thanks. It's a static function, so I agree that there's no need to
keep an unused parameter.

Pushed.

David