Horton

Re: If a row-level security policy contains a set returning function, pg_dump returns an incorrect serialization of that policy if the return type of the function was altered

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Timo Stolz <timo.stolz@nullachtvierzehn.de>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Jonas Reinsch <jonas.reinsch@pitchview.de>, Laura Schlimmer <laura.schlimmer@pitchview.de>
Date: 2022-07-22T16:50:29Z
Lists: pgsql-bugs 
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Thu, 21 Jul 2022 at 20:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Here's a proposed patch for that.  I wouldn't consider pushing this
>> into released branches, but maybe it's not too late for v15?

> That looks reasonable to me. It covers all the cases I could think of
> to try, and I can't see any loopholes. +1 for applying it to v15.

Thanks for checking it!

I had second thoughts about removing the old test cases: that would
leave us with no test coverage for the executor's defenses against
bad plans.  I'm not so foolish as to imagine we'll never introduce
another bug that would reach those defenses.  So what I did was to
adjust those cases to manually delete the new pg_depend entries,
allowing us to still test what happens without 'em.

Pushed that way.

			regards, tom lane

Commits

  1. Close old gap in dependency checks for functions returning composite.

  2. Fix ruleutils issues with dropped cols in functions-returning-composite.