Horton

Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-22T15:46:29Z
Lists: pgsql-hackers 
Fabien COELHO <coelho@cri.ensmp.fr> writes:
> Given these results, I do not think that it is useful to change 
> random_zipfian TAP test parameter from 2.5 to something else.

I'm not following this argument.  The test case is basically useless
for its intended purpose with that parameter, because it's highly
likely that the failure mode it's supposedly checking for will be
masked by the "random" function's tendency to spit out the same
value all the time.  We might as well drop zipfian from the test
altogether and save ourselves some buildfarm cycles.

			regards, tom lane

Commits

  1. Fix portability problem in pgbench.

  2. Avoid assuming that we know the spelling of getopt_long's error messages.