Re: Add missing PQclear for StreamLogicalLog function

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Steven Niu <niushiji@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-03-19T10:03:42Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_basebackup: Add missing PQclear in error path
- a19db0827496 18.0 landed

> On 19 Mar 2025, at 06:38, Steven Niu <niushiji@gmail.com> wrote:

> During browsing the code, I found one missing PQclear in function StreamLogicalLog(). It's a very small problem as it only happens in error condition. However since another similar patch was accepted,
> maybe we should also fix this one.

Thanks for the report, the patch looks reasonable so I'll have a look at
applying it once back from travelling.

--
Daniel Gustafsson