Re: unaccent(text) fails depending on search_path (WAS: pg_upgrade fails saying function unaccent(text) doesn't exist)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Gunnlaugur Thor Briem <gunnlaugur@gmail.com>, Adrian Klaver <adrian.klaver@aklaver.com>, pgsql-hackers@lists.postgresql.org
Date: 2018-09-07T22:43:52Z
Lists: pgsql-hackers, pgsql-general
Bruce Momjian <bruce@momjian.us> writes:
> If we are going down this route, is there any thought of handling
> earchdistance the same way?
> 	https://www.postgresql.org/message-id/20180330205229.GS8476@momjian.us

AFAICS there are no internal-to-the-C-code search path dependencies
in earthdistance.c, so it's not the same problem.

			regards, tom lane


Commits

  1. Make contrib/unaccent's unaccent() function work when not in search path.

  2. Avoid unnecessary use of pg_strcasecmp for already-downcased identifiers.