lowering pg_regress privileges on Windows

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Date: 2018-10-18T12:31:11Z
Lists: pgsql-hackers

Attachments

 From the "scratch a long running itch" department.


The attached ridiculously tiny patch solves the problem whereby while we 
can run Postgres on Windows safely from an Administrator account, we 
can't run run the regression tests from the same account, since it fails 
on the tablespace test, the tablespace directory having been set up 
without first having lowered privileges. The solution is to lower 
pg_regress' privileges in the same way that we do with other binaries. 
This is useful in setups like Appveyor where running under any other 
account is ... difficult. For the cfbot Thomas has had to make the 
script hack the schedule file to omit the tablespace test. This would 
make that redundant.


I propose to backpatch this. It's close enough to a bug and the risk is 
almost infinitely small.


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Lower privilege level of programs calling regression_main