Horton

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Victor Wagner <vitus@wagner.pp.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-09-04T23:02:02Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> ... Note that we've previously encountered similar issues
> on gcc, which is why we've tried to force gcc's hand with
> -fexcess-precision=standard.

Right.  Annoying that clang doesn't have that.  We can't realistically
program around an issue that might or might not show up depending on the
whims of the compiler's register allocation.

> I kinda wonder if we should add -mno-x87 or such in configure when we
> detect clang, obviously it doesn't deal correctly with this.

Seems worth looking into, but what happens if someone tries to compile
for x87 hardware?  Or do we care anymore?

			regards, tom lane

Commits

  1. Error out for clang on x86-32 without SSE2 support, no -fexcess-precision.

  2. Fix 8a934d677 for libc++ and make more include order resistant.