Horton

Re: BUG #18959: Name collisions of expression indexes during parallel Index creations on a pratitioned table.

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, maximilian.chrzan@here.com, pgsql-hackers@lists.postgresql.org
Date: 2025-09-15T20:06:26Z
Lists: pgsql-bugs, pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve the names generated for indexes on expressions.

  2. Use SnapshotDirty when checking for conflicting index names.

  3. Change the names generated for child foreign key constraints.

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Sep 15, 2025 at 12:15 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> So, how do we move forward?  I'm perfectly willing to look into
>> the derive-a-name-from-the-expression idea, but I think that'd
>> best be done in a separate patch.

> I'm not sure. To me, the munging of everything together under the name
> "expr" is the root of the problem here, and since this patch isn't
> really addressing that problem, it's kind of to one side of what I see
> as the main point. However, that's a judgement call, and if you or
> others see it differently, then so be it.

Well, let's leave it as a difference of opinion for the moment.
I do agree that improving the names generated for expression indexes
would be useful independently of this.  I propose setting this patch
aside for the time being, and I will go look into that, and then
if that gets accepted we can come back here and discuss how much
of a problem remains.

			regards, tom lane