Re: [HACKERS] Optional message to user when terminating/cancelling backend
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
Thomas Munro <thomas.munro@enterprisedb.com>,
Andres Freund <andres@anarazel.de>,
Onder Kalaci <onder@citusdata.com>,
PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-10-01T12:37:42Z
Lists: pgsql-hackers
Attachments
- 0001-Refactor-backend-signalling-code-v16.patch (application/octet-stream) patch v16-0001
- 0002-Support-optional-message-in-backend-cancel-terminate-v16.patch (application/octet-stream) patch v16-0002
> On 1 Oct 2018, at 01:19, Michael Paquier <michael@paquier.xyz> wrote: > > On Sun, Sep 30, 2018 at 10:51:44PM +0900, Michael Paquier wrote: >> You could have chosen something less complicated, like "ホゲ", which is >> the equivalent of "foo" in English. Anyway, non-ASCII characters should >> not be included in the final patch. Fixed in the attached v16 revision. > Looking at the refactoring patch 0001, wouldn't signalfuncs.c make a > better name for the new file? There are already multiple examples of > this type, like logicalfuncs.c, slotfuncs.c, etc. I have no strong feelings on this, I was merely using the name that Alvaro suggested when he brought up the refactoring as an extension of this patch. signalfuncs.c is fine by me, so I did this rename in the attached revision. > I have moved this patch set to the next commit fest for now. Thanks. cheers ./daniel
Commits
-
Refactor user-facing SQL functions signalling backends
- 09921f397b84 12.0 landed
-
Introduce 64-bit hash functions with a 64-bit seed.
- 81c5e46c490e 11.0 cited