Re: Should contrib modules install .h files?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2018-07-02T20:46:04Z
Lists: pgsql-hackers
Andrew Gierth <andrew@tao11.riddles.org.uk> writes: > Two questions arise: > 1) include/server has a lot of files and subdirs, so using > include/server/$(MODULE)/ looks likely to be error-prone. So it > should be something like include/server/contrib/$(MODULE)/ or > include/server/extension/$(MODULE)/. Which one, or should it use > $(MODULEDIR) to choose between the two the way that DATA and DOCS do? > Or something else? Might as well follow the MODULEDIR precedent (though I'm not wedded to that if somebody has an argument for something else). > 2) Specifying HEADERS_blah for some name "blah" that's not listed in > MODULES or MODULE_big should do what: > a) install into blah/ anyway > b) be ignored with a warning > c) be silently ignored > d) be an error I'd definitely vote for "error". Likewise if any .h file listed in the macro doesn't exist. regards, tom lane
Commits
-
Fix out-of-tree build for transform modules.
- f1ca5a654d5d 11.0 landed
- 60f6756f9225 12.0 landed
-
Provide for contrib and pgxs modules to install include files.
- df163230b92b 12.0 landed
- d06eebce5fa4 11.0 landed