Horton

Re: Should we remove -Wdeclaration-after-statement?

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Jelte Fennema-Nio <postgres@jeltef.nl>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, "ranier.vf@gmail.com" <ranier.vf@gmail.com>, chap@anastigmatix.net
Date: 2024-01-31T06:48:51Z
Lists: pgsql-hackers 
On 29.01.24 16:03, Jelte Fennema-Nio wrote:
> I feel like this is the type of change where there's not much
> discussion to be had. And the only way to resolve it is to use some
> voting to gauge community opinion.
> 
> So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
> +1 to indicate support against/for the change.
> 
> I'll start: +1
> 
> Attached is a patch that removes -Wdeclaration-after-statement in the
> codebase. This is mainly to be able to add it to the commitfest, to
> hopefully get a decent amount of responses.

-1, mostly for the various reasons explained by others.