Horton
Menu

Re: head fails to build on SLES 12 (wal_compression=zstd)

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Devrim Gündüz <devrim@gunduz.org>, pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Date: 2022-03-31T15:44:40Z
Lists: pgsql-hackers 
Justin Pryzby <pryzby@telsasoft.com> writes:
> Possible responses look like:
>  - Use 0 which also means "default" (need to verify that works across versions);
>  - Or #ifndef ZSTD_CLEVEL_DEFAULT #define ZSTD_CLEVEL_DEFAULT 3;
>  - Add a test for a minimum zstd version v1.3.7.  This may be a good idea for
>    v15 in any case, since we're using a few different APIs (at least
>    ZSTD_compress and ZSTD_compressStream2 and execve(zstd)).

In view of 51c0d186d ("Allow parallel zstd compression"), I agree
that some clarity about the minimum supported version of zstd
seems essential.  I don't want to be dealing with threading bugs
in ancient zstd versions.  However, why do you suggest 1.3.7 in
particular?

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Set minimum required version of zstd as 1.4.0.

  2. Add support for zstd with compression of full-page writes in WAL