Horton
Menu

Re: Adding CI to our tree

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Melanie Plageman <melanieplageman@gmail.com>
Date: 2021-12-15T15:45:52Z
Lists: pgsql-hackers 
> On 15 Dec 2021, at 16:21, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Justin Pryzby <pryzby@telsasoft.com> writes:
>> On Mon, Dec 13, 2021 at 03:45:23PM -0800, Andres Freund wrote:
>>> On 2021-12-13 18:14:52 -0500, Tom Lane wrote:
>>>> I'm with Justin on this one.  I would view a script trying to
>>>> mess with /cores as a hostile act.
> 
>>> I'm not quite following. This is a ephemeral CI instance?
> 
>> As for myself, all I meant is that it's better to write it with zero sudos than
>> one (for the same reason that it's better to write with one than with two).
> 
> What I'm concerned about is that it's unsafe to run the script in
> any non-throwaway environment.  That doesn't seem desirable.

I don't think anyone should expect any part of the .cirrus.yml script to be
safe or applicable to a local environment, so I think this is something we can
solve with documentation.

--
Daniel Gustafsson		https://vmware.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. ci: enable zstd where available.

  2. ci: compile with -Og where applicable.

  3. ci: include hints how to install OS packages.

  4. ci: fix copy-paste mistake in 16eb8231d1b.

  5. ci: macos: align sysinfo_script to other tasks.

  6. ci: Only use one artifact instruction for logs.

  7. ci: s/CCACHE_SIZE/CCACHE_MAXSIZE/.

  8. pg_basebackup: Skip a few more fsyncs if --no-sync is specified.

  9. TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.

  10. Don't enable fsync in src/test/recovery/t/008_fsm_truncation.pl.

  11. ci: windows: run initdb with --no-sync.

  12. ci: windows: enable build summary to make it easier to spot warnings / errors.

  13. ci: Add continuous integration for github repositories via cirrus-ci.

  14. Fix TestLib::slurp_file() with offset on windows.