Horton

Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

NISHIYAMA Tomoaki <tomoakin@staff.kanazawa-u.ac.jp>

View thread
From: NISHIYAMA Tomoaki <tomoakin@staff.kanazawa-u.ac.jp>
To: Magnus Hagander <magnus@hagander.net>
Cc: NISHIYAMA Tomoaki <tomoakin@staff.kanazawa-u.ac.jp>, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Date: 2011-12-03T14:49:47Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove troublesome Asserts in cost_mergejoin().

  2. Enable building with the Mingw64 compiler.

Hi,

> Have you verified if tihs affects _MSC_VER < 1400? Suddently that
> branch would care about HAVE_CRTDEFS_H, and I'm not sure if that's
> something we need to worry about.


I have no MSVC. In that sense it is not verified in fact, and I hope
those who knows well would kindly comment on it.

However, it appears that pg_config.h is not created through
configure, but just copied from pg_config.h.win32 in those
compilers and thus HAVE_CRTDEFS_H will not be defined.
So, I think this code fragment will not be enabled in
_MSC_VER < 1400

In addition, the code fragment should have no harm as far as they
have crtdefs.h.
(Again, this is I think it should, and not tested with real tools.)

On 2011/12/03, at 23:20, Magnus Hagander wrote:

> On Sat, Dec 3, 2011 at 09:24, NISHIYAMA Tomoaki
> <tomoakin@staff.kanazawa-u.ac.jp> wrote:
>> Hi,
>> 
>> A new patch:
>> check for the presence of crtdefs.h in configure
>> 
>> -#if _MSC_VER >= 1400 || defined(WIN64)
>> +#if _MSC_VER >= 1400 || HAVE_CRTDEFS_H
>>  #define errcode __msvc_errcode
>>  #include <crtdefs.h>
>>  #undef errcode
> 
> Have you verified if tihs affects _MSC_VER < 1400? Suddently that
> branch would care about HAVE_CRTDEFS_H, and I'm not sure if that's
> something we need to worry about.
> 
> -- 
>  Magnus Hagander
>  Me: http://www.hagander.net/
>  Work: http://www.redpill-linpro.com/
> 
> -- 
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>